FEAT: inspect quantum number solutions #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
force-pushed
the
visualize-quantum-number-solutions
branch
from
bc7a938 to
104d7aa
Compare
redeboer
force-pushed
the
visualize-quantum-number-solutions
branch
from
104d7aa to
5f245c4
Compare
This is especially useful to represent objects returned by StateTransitionManager._solve()
Also fixes some of the naming: "particles" becomes "quantum_numbers"
redeboer
force-pushed
the
visualize-quantum-number-solutions
branch
from
5f245c4 to
bb84107
Compare
redeboer
changed the title
Needed for `tqdm`
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
StateTransitionManager.find_solutions()method internally consists of a few steps:ProblemSets toQNProblemSetss (basicallyParticlewith spin projection to adict)_solve()method, which constructs aCSPSolverParticleinstances by matching the found quantum number sets withParticledefinitions in the STM's particle database.ReactionInfoobject and returning it.This is quite a lot of responsibility and makes it hard to debug a problem like #165. This PR splits up the
find_solutions()method and extends theio._dotmodule so that it can visualize the quantum number sets before finding the matchingParticledefinitions.