ENH: warn instead of raise violated rules #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, when there are violated rules and/or non-executed rules,
find_solutions()
raises these as aRuntimeWarning
. This is an incorrect use of this exception class that also prevents the user from inspecting the execution info. TheRuntimeWarning
is therefore now passed throughwarnings.warn()
. The warnings can then be switch off with:Still, if there are violated rules, there are no solutions, so an exception is still raised (now as a
RuntimeError
instead of aValueError
.ExecutionInfo
is now passed on to this exception, so that it can be further inspected:See also #174