FEAT: implement quantum problem set filter #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redeboer
changed the title
for more information, see https://pre-commit.ci
…o filter_quantum_numbers
redeboer
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Nice that it's working 🙌
(After offline discussion):
Let's expose this filter_quantum_number_problem_set() function and write an example with visualization in the "Conservation rules" notebook. If that turns out to look concise, illustrative, and useable enough, we can keep this new function in the API.
Perhaps the example can be without C-parity conservation? As opposed to the test.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
redeboer
reviewed
Oct 30, 2024
redeboer
requested changes
Oct 30, 2024
…o filter_quantum_numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
CSPSolver.find_solutions()just takes a generalQNProblemSetit should be possibleto reduce the set of constraints (i.e. conservation rules) the solver takes into account for
finding the solutions of a decay.
A possible way to implement this is to use the
StateTransitionManagerto generate thefull set of rules for a certain decay and just filter it to contain only the desired
constraints before passing it to
CSPSolver.Closes #297
Tip
See preview of the modified documentation here.