Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: implement FrozenDict with frozendict #310

Merged
merged 20 commits into from
Dec 20, 2024
Merged

ENH: implement FrozenDict with frozendict #310

merged 20 commits into from
Dec 20, 2024
+97 −68

Conversation

redeboer
Copy link
Member

Closes #309

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Dec 19, 2024
@redeboer redeboer added this to the 0.10.4 milestone Dec 19, 2024
@redeboer redeboer self-assigned this Dec 19, 2024
@redeboer
Copy link
Member Author

Some obscure things related to ComPWA/ampform#444 (comment)...

  • As opposed to ComPWA/ampform@8a9a171, the hash of FrozenDict is already stable in QRules before switching to frozendict
  • Even after switching to frozendict, the hash of a ReactionInfo object still is not stable

@redeboer redeboer marked this pull request as ready for review December 20, 2024 11:19
@redeboer redeboer merged commit 769ade3 into main Dec 20, 2024
26 checks passed
@redeboer redeboer deleted the frozendict branch December 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@redeboer redeboer

Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
0.10.4
Development

Successfully merging this pull request may close these issues.

Use frozendict package instead of custom FrozenDict class
2 participants
@redeboer @web-flow