Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add benchmarks (skeleton) #106

Closed
wants to merge 16 commits into from
Closed

feat: add benchmarks (skeleton) #106

wants to merge 16 commits into from

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Jul 1, 2020

Closes #103

@redeboer redeboer marked this pull request as draft July 1, 2020 19:50
@redeboer redeboer added 🖱️ DX Improvements to the Developer Experience 🕐 Trivial labels Jul 1, 2020
@redeboer redeboer added this to the Finalize dev environment milestone Jul 1, 2020
@redeboer redeboer added 💡 Enhancement ❔ Question Discuss this matter in the team and removed 🕐 Trivial labels Jul 1, 2020
@redeboer redeboer requested a review from spflueger July 1, 2020 19:52
@redeboer
Copy link
Member Author

redeboer commented Jul 1, 2020

@spflueger We'll need so think of a smart way to smear the initial parameters after data generation and before fit. Will also need to put the example recipe files -- created with benchmark/create_recipe.py -- under source control, so that we can things like omega mass width a bit more wide.

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   78.73%   78.73%           
=======================================
  Files          14       14           
  Lines         649      649           
=======================================
  Hits          511      511           
  Misses        138      138           

@spflueger
Copy link
Member

@spflueger We'll need so think of a smart way to smear the initial parameters after data generation and before fit. Will also need to put the example recipe files -- created with benchmark/create_recipe.py -- under source control, so that we can things like omega mass width a bit more wide.

That's true. Can you open an issue for this random initial parameter problem.

I think its totally ok uploading a fixed model recipe for testing purposes.

@redeboer
Copy link
Member Author

redeboer commented Jul 2, 2020

That's true. Can you open an issue for this random initial parameter problem.

There's already this one, right? ComPWA/expertsystem#8

@redeboer
Copy link
Member Author

redeboer commented Jul 2, 2020

@spflueger 2d6d300 still doesn't address the problem, because there's no clean way to fix or modify width and mass from the python interface.

@spflueger
Copy link
Member

That's true. Can you open an issue for this random initial parameter problem.

There's already this one, right? ComPWA/expertsystem#8

This is something else. Or did I misunderstand you here? You are talking about some function which randomly picks a starting point in the optimization space right?

@redeboer redeboer removed this from the Finalize dev environment milestone Jul 30, 2020
@redeboer redeboer closed this Nov 2, 2020
@redeboer redeboer deleted the redeboer/issue103 branch November 2, 2020 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🖱️ DX Improvements to the Developer Experience ❔ Question Discuss this matter in the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide benchmarks tests
2 participants