-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add angular distribution tests from pycompwa #182
Conversation
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 82.85% 83.66% +0.80%
==========================================
Files 13 13
Lines 700 704 +4
Branches 96 97 +1
==========================================
+ Hits 580 589 +9
+ Misses 87 83 -4
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I would just keep this PR as it is and @Leongrim and @sebastianJaeger can add their channels in follow up PRs. It also reflects the title this way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Just have some comments about the structure of the angular_distributions
folder. That's related to #182 (comment) as well
...ysics/helicity_formalism/angular_distributions/epem_to_dm_d0_pip_decay/test_distributions.py
Outdated
Show resolved
Hide resolved
...ysics/helicity_formalism/angular_distributions/epem_to_dm_d0_pip_decay/test_distributions.py
Outdated
Show resolved
Hide resolved
tests/physics/helicity_formalism/angular_distributions/epem_to_dm_d0_pip_decay/model.yml
Outdated
Show resolved
Hide resolved
tests/physics/helicity_formalism/angular_distributions/d1_to_d0_pi_pi_decay/__init__.py
Outdated
Show resolved
Hide resolved
tests/physics/helicity_formalism/angular_distributions/conftest.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So apart from #182 (comment), I think we can move on with this PR
First test is ported from
pycompwa
, together with some fixture code.I also made a small change to the variable names, as they were not consistent.
The second one I will tackle tomorrow. But this will serve as the baseline for all other distribution test.
@redeboer @Leongrim @sebastianJaeger , take a look if you like the test setup. Ideally I would like you to possibly extend this with your channels.
Closes #181
TODOs: