refactor: extend Callback interface #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add on_optimize_start and on_optimize_end to Callback interface, defining events at the beginning and the end of the complete optimization procedure.
Verify the the invocation order of the various callback events.
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
==========================================
- Coverage 81.65% 80.92% -0.74%
==========================================
Files 12 12
Lines 507 540 +33
Branches 64 68 +4
==========================================
+ Hits 414 437 +23
- Misses 71 81 +10
Partials 22 22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
redeboer
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #230