-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Company project 3 #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added new icons for the mobile design - added new components for the mobile design - added new pages for the mobile design - added new css for the mobile design - added new images for the mobile design - added new utility for the mobile design - added new icon utility for the mobile design - removed unused components - removed unused images - removed unused css - removed unused utility - removed unused pages
- E18MuurlaForm Implementation - refactoring of the project structure and components - adding input logic for the E18MuurlaForm with firebase - implementation of sycned post for notification when coming online - css implementation for input fields in form - code clean up for css and js - mobile responsive design for the form
- forntend and backend to be deployed seprately - css for typeselector fix - css for nav bar fix
This commit adds a new `vercel.json` file to the backend directory, which specifies the build configuration for the Vercel deployment. It includes the source file `server.js` and uses the `@vercel/node` builder. Additionally, it sets up rewrites and headers to enable CORS (Cross-Origin Resource Sharing) for the API endpoints.
… deployment and Vercel support
This commit updates the index.html file in the Frontend/public directory to comment out the favicon link. This change is made to improve security by preventing the loading of the favicon.ico file from the public URL. Additionally, the vercel.json file in the backend directory is modified to add a Content-Security-Policy header with the value 'default-src 'none''. This enhances security by specifying that no resources should be loaded from any source by default. These changes aim to improve the security of the application.
The Content-Security-Policy header in the vercel.json file is updated to set the value to 'none' instead of 'default-src 'none''. This change enhances security by explicitly specifying that no resources should be loaded from any source by default.
…base configuration The FirebaseConfig.js file is modified to use environment variables for the Firebase configuration values instead of hardcoding them. This change improves security by preventing sensitive information from being exposed in the codebase. This commit follows the established convention of using the "chore" type for non-functional changes that do not affect the behavior of the code.
The vercel.json file is modified to remove the rewrites section and update the headers section. This change aims to improve the configuration of the Vercel deployment by removing unnecessary rewrites and making modifications to the headers. This commit follows the established convention of using the "chore" type for non-functional changes that do not affect the behavior of the code.
…iable REACT_APP_API_URI .
- Refactor WeatherCondition component to use more descriptive prop names
deployment successful at Kaiku |
can be merge without conflict with the base branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Frontend (React): The frontend follows a typical Create React App structure with some custom additions:
public/:
Contains the entry HTML file and PWA-related files.idb.js
,sw.js
, andutility.js
to the public folder is a good choice for PWA functionality, as it makes these files directly accessible.src/:
Contains the React application source code.Common
,E18MuurlaForm
,Homepage
) suggests a modular approach, which is excellent for maintainability.NavBar
andNavbarIconUtility
folders indicate attention to reusable UI components.Public/Assets/Icons/:
Storing icons separately is a good practice for asset management.