Improve IpAddress#toString API/docs.
#553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
to elaborate on the commit message, if you click through |
|
Thanks, looks good to me! We just need a mima exclusion. |
Add protected method to `IpAddress` that `#toString` delegates to, making it clearer to users from the `IpAddress` trait alone that `#toString` returns a reasonable representation (and the one they want).
NthPortal
force-pushed
the
better-toString/PR
branch
from
6733bd7 to
75d632e
Compare
sorry this took so long for me to get to. life happened at me. but it's done now |
|
No worries, and thanks for fixing that typo. Auto-correct got me again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add protected method to
IpAddressthat#toStringdelegates to, making it clearer to users from theIpAddresstrait alone that#toStringreturns a reasonable representation (and the one they want).