Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Move browser prompt / alerts to Vue side #1018

Closed
1 task done
robinjhuang opened this issue Sep 27, 2024 · 0 comments · Fixed by #1112
Closed
1 task done

[Feature Request]: Move browser prompt / alerts to Vue side #1018

robinjhuang opened this issue Sep 27, 2024 · 0 comments · Fixed by #1112
Assignees
Labels
enhancement New feature or request

Comments

@robinjhuang
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Can we improve the look and feel of the prompts for saving workflows and other alerts to Vue side. This gives us more control over the user experience.

Would be good to override the native browser prompt and alert in the window object as well so all custom nodes can benefit from this.

One example

https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/scripts/workflows.ts#L369

Proposed workflow

See above

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants