Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace window.alert with toast alert #1112

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Replace window.alert with toast alert #1112

merged 2 commits into from
Oct 5, 2024

Conversation

huchenlei
Copy link
Member

Closes #1018

image

There are still leftover browser API call in group node code, I will cleanup them once we started rework group node interactions.

@huchenlei huchenlei merged commit 4cc6954 into main Oct 5, 2024
9 checks passed
@huchenlei huchenlei deleted the clear_alert branch October 5, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Move browser prompt / alerts to Vue side
1 participant