Add test for selecting nodes on mac #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-byrne
commented
Oct 1, 2024
| @@ -914,13 +924,15 @@ export class ComfyPage { | |||
| return new NodeReference(id, this) | |||
| } | |||
| async getNodeRefsByType(type: string): Promise<NodeReference[]> { | |||
There was a problem hiding this comment.
Assumed this is intended return type based on annotation
huchenlei
added
the
New Browser Test Expectations
huchenlei
approved these changes
Oct 1, 2024
|
@christian-byrne Do you have any idea why the test fails even after Comfy-Org/litegraph.js#182 has been merged? |
|
I thought it was because litegraph version wasn't updated yet |
The commit should be included in v0.7.81 litegraph which was updated yesterday in #1050 |
|
Not sure. I can fix when home 6 pst |
huchenlei
removed
the
New Browser Test Expectations
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests from Comfy-Org/litegraph.js#182 (drag-select on Mac)