New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show in-progress preview of the running task in the queue #1091

Merged

huchenlei merged 1 commit into Comfy-Org:main from bezo97:feature/queue-progress-preview

Oct 3, 2024

Collaborator

bezo97 commented Oct 3, 2024

Implemented the requested feature to show in-progress preview of the running task
The existing spinner is shown before the first preview image is available
I've added a spinner to the Running label to indicate progress even when the preview updates are slow
Also works when there are multiple samplers

Closes #581


          Show in-progress preview of the running task in the queue

dbd75b7

huchenlei added the enhancement label

huchenlei approved these changes

View reviewed changes

Member

huchenlei left a comment

Very nice! Thanks for the contribution!

Note:
You need to add --preview-method auto cmd launch args to test this feature as the default preview method is none.

huchenlei merged commit 661b808 into Comfy-Org:main

9 checks passed

bezo97 deleted the feature/queue-progress-preview branch

October 3, 2024 22:53

JorgeR81 mentioned this pull request

[Feature Request]: in-progress preview node #1093

Open

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels