Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount vue app after comfy app init #167

Merged
merged 7 commits into from
Jul 19, 2024
Merged

Mount vue app after comfy app init #167

merged 7 commits into from
Jul 19, 2024

Conversation

huchenlei
Copy link
Member

Swap init over of ComfyApp and Vue app. This can avoid Vue app requesting /object_info an extra time.

@huchenlei huchenlei changed the title Mount vue app after comfy app Mount vue app after comfy app init Jul 19, 2024
@huchenlei huchenlei added the enhancement New feature or request label Jul 19, 2024
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Jul 19, 2024
@huchenlei
Copy link
Member Author

Example test expectation diff:
image

The checkbox background is not loaded, as prime vue's css not fully loaded when vue app is loaded.

@huchenlei huchenlei merged commit a2afdd7 into main Jul 19, 2024
2 checks passed
@huchenlei huchenlei deleted the init_order branch July 20, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant