feat: Add more server side arguments #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
requested changes
Dec 8, 2024
huchenlei
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Can you link the correct change in the desktop repo? Currently the link points to this specific frontend repo PR.
resolves Comfy-Org/desktop#424
desktop dependency: #1846
huchenlei
force-pushed
the
enh/Add-more-server-side-arguments
branch
from
0b96028 to
cc60713
Compare
|
Changes made:
On the electron side support configuring of host and port: |
huchenlei
approved these changes
Dec 12, 2024
This was referenced Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves Comfy-Org/desktop#424
desktop dependency: Comfy-Org/desktop#465