Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename EditAttention to EditTokenWeight #1848

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Rename EditAttention to EditTokenWeight #1848

merged 4 commits into from
Dec 9, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Dec 8, 2024

According to @ltdrdata, EditAttention name can be misleading, and EditTokenWeight would be a better name describing the feature.

image

@huchenlei huchenlei requested a review from a team as a code owner December 8, 2024 22:33
@github-actions github-actions bot requested review from shinshin86 and a team as code owners December 8, 2024 22:35
@huchenlei huchenlei merged commit b4ccaf4 into main Dec 9, 2024
8 of 10 checks passed
@huchenlei huchenlei deleted the rename_attn_edit branch December 9, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant