Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0 Side Bar & Menu rework #189

Merged
merged 13 commits into from
Jul 22, 2024
Merged

v1.2.0 Side Bar & Menu rework #189

merged 13 commits into from
Jul 22, 2024

Conversation

huchenlei
Copy link
Member

@huchenlei huchenlei commented Jul 21, 2024 •
edited
Loading

This PR implements a sidebar that now host the queue information.

image

@huchenlei
Basic side tool bar skeleton + Theme toggle (#164)
a5727c0 
* Side bar skeleton

* Fix grid layout

* nit

* Add theme toggle logic
@huchenlei
Change primevue color theme to blue to match beta menu UI
88f7e29
@huchenlei
Add litegraph canvas splitter overlay (#177)
8fcb207 
* Add vue wrapper

* Splitter overlay

* Move teleport to side bar comp

* Toolbar placeholder
@huchenlei
Move settings button from top menu to side bar (#178)
5159501
@huchenlei
Reverse relationship between splitter overlay and sidebar component (#…
35015a7 
…180)

* Reverse relationship between splitter overlay and sidebar component

* nit

* Remove border on splitter
@huchenlei
Fix canvas shift (#186)
4686356
@huchenlei huchenlei changed the title Dev1.2 Side Bar & Menu rework v1.2.0 Side Bar & Menu rework Jul 21, 2024
@huchenlei
Merge remote-tracking branch 'origin/main' into dev1.2
d357794
@huchenlei
Move queue/history display to side bar (#185)
a9762b6 
* Side bar placeholder

* Pinia store for queue items

* Flatten task item

* Fix schema

* computed

* Switch running / pending order

* Use class-transformer

* nit

* Show display status

* Add tag severity style

* Add execution time

* nit

* Rename to execution success

* Add time display

* Sort queue desc order

* nit

* Add remove item feature

* Load workflow

* Add confirmation popup

* Add empty table placeholder

* Remove beta menu UI's queue button/list
@socket-security Socket Security
Copy link

socket-security bot commented Jul 21, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/class-transformer@0.5.1 None 0 776 kB typestack-release-bot
npm/pinia@2.1.7 environment Transitive: filesystem +2 440 kB posva
npm/reflect-metadata@0.2.2 None 0 241 kB rbuckton

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jul 21, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/vue-demi@0.14.8

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@huchenlei
Copy link
Member Author

@SocketSecurity ignore npm/vue-demi@0.14.8

@christian-byrne
Add tests on litegraph widget text truncate (#191)
1110729 
* Add tests on litegraph widget text truncate

* Updated screenshots

* Revert port change

* Remove screenshots
@huchenlei huchenlei added the New Browser Test Expectations New browser test screenshot should be set by github action label Jul 21, 2024
@huchenlei huchenlei marked this pull request as ready for review July 22, 2024 14:13
@huchenlei huchenlei merged commit 65740a3 into main Jul 22, 2024
4 checks passed
@huchenlei huchenlei deleted the dev1.2 branch July 22, 2024 14:16
This was referenced Jul 22, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
New Browser Test Expectations New browser test screenshot should be set by github action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huchenlei @christian-byrne