Reverse init order #227
Merged
Reverse init order #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
commented
Jul 26, 2024
| @@ -129,6 +130,9 @@ export class ComfyApp { | |||
| this.bodyLeft = $el('div.comfyui-body-left', { parent: document.body }) | |||
| this.bodyRight = $el('div.comfyui-body-right', { parent: document.body }) | |||
| this.bodyBottom = $el('div.comfyui-body-bottom', { parent: document.body }) | |||
| this.canvasContainer = $el('div.graph-canvas-container', { | |||
There was a problem hiding this comment.
This move is necessary as Vue requires teleport target to be available when the component is mounted. If we load ComfyApp after VueApp, the container need to inited in the constructor instead of setup function.
| <teleport to="#graph-canvas-container"> | ||
| <LiteGraphCanvasSplitterOverlay> | ||
| <teleport to=".graph-canvas-container"> | ||
| <LiteGraphCanvasSplitterOverlay v-if="betaMenuEnabled"> |
There was a problem hiding this comment.
Remove all overlay + sidebar when beta menu is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse init order of vue app and comfy app so that the custom node can call
app.extensionManagerwheninithook is called.