Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS type on InputSpec #901

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Fix TS type on InputSpec #901

merged 1 commit into from
Sep 21, 2024

Conversation

webfiltered
Copy link
Collaborator

Summary:

  • apiTypes: Removes explicit TS type-broadening to any from apiTypes.inputSpec function, allowing inference of the API to reach the exported types (assumption: this was previously required to compile).
  • apiTypes: Adds InputSpec as export
  • widgets: Corrects use of ComfyNodeDef to InputSpec
  • noteNode: Removes one ts-expect-error

huchenlei
huchenlei approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@huchenlei huchenlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@huchenlei huchenlei merged commit 88acabb into Comfy-Org:main Sep 21, 2024
9 checks passed
@webfiltered webfiltered deleted the inputspec-type branch September 21, 2024 07:40
@huchenlei huchenlei mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huchenlei huchenlei huchenlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webfiltered @huchenlei