Cleanup #915
Merged
Cleanup #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmx974
commented
Sep 22, 2024
dmx974
commented
- move reflect to main.ts
- add config.ts and global.d.ts to properly handle COMFYUI_FRONTEND_VERSION
- cleanup index.html and App.vue
- move reflect to main.ts - add config.ts with comfy frontend version - cleanup index.html and App.vue
huchenlei
reviewed
Sep 22, 2024
| useSettingStore().get('Comfy.ColorPalette') | ||
| ) | ||
|
|
||
| const { t } = useI18n() |
There was a problem hiding this comment.
Please revert some of the moves of stores, as it is an advantage of using composition API is that you can have declaration and usage at the same place. See https://vuejs.org/guide/extras/composition-api-faq.html for details.
There was a problem hiding this comment.
We are loosing time ... I perfectly know what is composition API, doing vue for more than 10 years now. Please merge that PR so I can continue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.