Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install extension adds @<version> at in the extension folder #9

Closed
huchenlei opened this issue Nov 17, 2024 · 1 comment · Fixed by comfyanonymous/ComfyUI#6107
Closed

Install extension adds @<version> at in the extension folder #9

huchenlei opened this issue Nov 17, 2024 · 1 comment · Fixed by comfyanonymous/ComfyUI#6107
Labels
bug Something isn't working

Comments

@huchenlei
Copy link
Member

The @<version> suffix in extension folder breaks the loading of frontend extensions.
@huchenlei huchenlei added the bug Something isn't working label Nov 17, 2024
@ltdrdata
Copy link
Member

ltdrdata commented Nov 18, 2024 •
edited
Loading

The @<version> suffix in extension folder breaks the loading of frontend extensions.

I think it would be better to use an escaped version of module_name in the core rather than using it as is.
https://github.com/comfyanonymous/ComfyUI/blob/d9f90965c8601b671faca9c8784b529e389c49aa/nodes.py#L2027

What do you think?

@huchenlei huchenlei mentioned this issue Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bug] Use raw dir name to serve static web content comfyanonymous/ComfyUI
2 participants
@huchenlei @ltdrdata