[Bug] Use raw dir name to serve static web content #6107
Merged
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
changed the title
huchenlei
added
Bug
|
Discussed with HCL offline. This should not cause any regressions because github does not allow special characters in their repository name anyways. So this was probably never needed in the first place. |
robinjhuang
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Comfy-Org/manager-core#9
The
urllib.parse.quote(name)was added in9b1d5a5#diff-791d4d41d3718d15d49180f3aacc8370b8cab07383f0d35b2713651cc0adfe46R511
However, it is causing issue if there are special characters in the custom node directory, such as
@. Previously the issue was not surfaced as github repo name cannot contain any special character that urlencode to something else, until the repo@version syntax was introduced by the manager.Step to reproduce