Fix input types from D13050

Summary: This differential fixes types according to Ashoat suggestion: https://phab.comm.dev/D13050#inline-76348 Test Plan: flow Reviewers: ashoat Reviewed By: ashoat Subscribers: tomek Differential Revision: https://phab.comm.dev/D13271
CommE2E · Sep 11, 2024 · 0e2412f · 0e2412f
1 parent 5e6ea06
commit 0e2412f
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 8 deletions.
diff --git a/keyserver/src/push/send.js b/keyserver/src/push/send.js
@@ -777,7 +777,9 @@ async function fetchInfos(pushInfo: PushInfo) {
 
 async function fetchNotifUserInfos(
   serverThreadInfos: { +[threadID: string]: ServerThreadInfo },
-  usersToCollapsableNotifInfo: { +[userID: string]: CollapsableNotifInfo[] },
+  usersToCollapsableNotifInfo: {
+    +[userID: string]: $ReadOnlyArray<CollapsableNotifInfo>,
+  },
 ) {
   const missingUserIDs = new Set<string>();
 

diff --git a/lib/push/send-utils.js b/lib/push/send-utils.js
@@ -94,7 +94,7 @@ export type CollapsableNotifInfo = {
 };
 
 export type FetchCollapsableNotifsResult = {
-  [userID: string]: CollapsableNotifInfo[],
+  +[userID: string]: $ReadOnlyArray<CollapsableNotifInfo>,
 };
 
 function identityPlatformDetailsToPlatformDetails(
@@ -302,9 +302,11 @@ function getOwnDevicesPushInfo(
 
 function pushInfoToCollapsableNotifInfo(pushInfo: PushInfo): {
   +usersToCollapseKeysToInfo: {
-    [string]: { [string]: CollapsableNotifInfo },
+    +[string]: { +[string]: CollapsableNotifInfo },
+  },
+  +usersToCollapsableNotifInfo: {
+    +[string]: $ReadOnlyArray<CollapsableNotifInfo>,
   },
-  +usersToCollapsableNotifInfo: { [string]: Array<CollapsableNotifInfo> },
 } {
   const usersToCollapseKeysToInfo: {
     [string]: { [string]: CollapsableNotifInfo },
@@ -348,13 +350,23 @@ function pushInfoToCollapsableNotifInfo(pushInfo: PushInfo): {
 
 function mergeUserToCollapsableInfo(
   usersToCollapseKeysToInfo: {
-    [string]: { [string]: CollapsableNotifInfo },
+    +[string]: { +[string]: CollapsableNotifInfo },
+  },
+  usersToCollapsableNotifInfo: {
+    +[string]: $ReadOnlyArray<CollapsableNotifInfo>,
   },
-  usersToCollapsableNotifInfo: { [string]: Array<CollapsableNotifInfo> },
-): { [string]: Array<CollapsableNotifInfo> } {
-  const mergedUsersToCollapsableInfo = { ...usersToCollapsableNotifInfo };
+): { +[string]: $ReadOnlyArray<CollapsableNotifInfo> } {
+  const mergedUsersToCollapsableInfo: {
+    [string]: Array<CollapsableNotifInfo>,
+  } = {};
+
   for (const userID in usersToCollapseKeysToInfo) {
     const collapseKeysToInfo = usersToCollapseKeysToInfo[userID];
+
+    mergedUsersToCollapsableInfo[userID] = [
+      ...usersToCollapsableNotifInfo[userID],
+    ];
+
     for (const collapseKey in collapseKeysToInfo) {
       const info = collapseKeysToInfo[collapseKey];
       mergedUsersToCollapsableInfo[userID].push({