[lib] Allow reacting and creating sidebars from failed messages in th…

…ick threads

Summary: https://linear.app/comm/issue/ENG-9313/consider-allowing-creating-sidebars-from-messages-that-failed#comment-dc22d82f

Test Plan: Checked on native and web if the actions are present for failed messages in thick threads and aren't present for failed messages in thin threads.

Reviewers: kamil, will

Reviewed By: will

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D13362

lib/shared/reaction-utils.js

@@ -14,6 +14,7 @@ import type {
 } from '../types/message-types.js';
 import type { ThreadInfo } from '../types/minimally-encoded-thread-permissions-types.js';
 import { threadPermissions } from '../types/thread-permission-types.js';
+import { threadTypeIsThick } from '../types/thread-types-enum.js';
 import { useSelector } from '../utils/redux-utils.js';
 
 function useViewerAlreadySelectedMessageReactions(
@@ -92,8 +93,9 @@ function useCanCreateReactionFromMessage(
   }
 
   if (
-    !targetMessageInfo.id ||
-    threadInfo.sourceMessageID === targetMessageInfo.id
+    (!targetMessageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+    (threadInfo.sourceMessageID &&
+      threadInfo.sourceMessageID === targetMessageInfo.id)
   ) {
     return false;
   }

lib/shared/sidebar-utils.js

@@ -210,8 +210,9 @@ function useCanCreateSidebarFromMessage(
   }
 
   if (
-    !messageInfo.id ||
-    threadInfo.sourceMessageID === messageInfo.id ||
+    (!messageInfo.id && !threadTypeIsThick(threadInfo.type)) ||
+    (threadInfo.sourceMessageID &&
+      threadInfo.sourceMessageID === messageInfo.id) ||
     isInvalidSidebarSource(messageInfo)
   ) {
     return false;