support chain spec #138
Merged
support chain spec #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbrv
reviewed
Sep 30, 2024
| @@ -46,6 +47,17 @@ pub fn handle_docker_init(config_path: String, output_dir: String) -> Result<()> | |||
|
|
|||
| // config volume to pass to all services | |||
| let config_volume = Volumes::Simple(format!("./{}:{}:ro", config_path, CONFIG_DEFAULT)); | |||
| let chain_spec_volume = chain_spec_path.as_ref().and_then(|p| { | |||
There was a problem hiding this comment.
maybe:
let get_file_name_str = |p: &Path| -> Option<&str> {
p.file_name()?.to_str()
};
// chain_spec_volume using the helper
let chain_spec_volume = chain_spec_path.as_ref().and_then(|p| {
let file_name = get_file_name_str(p)?;
Some(Volumes::Simple(format!("{}:/{}:ro", p.display(), file_name)))
});
// chain_spec_env using the helper
let chain_spec_env = chain_spec_path.and_then(|p| {
let file_name = get_file_name_str(&p)?;
Some(get_env_val(CHAIN_SPEC_ENV, &format!("/{file_name}")))
});There was a problem hiding this comment.
mm not sure this is more legible
| pub fn from_env_path() -> Result<Self> { | ||
| let config: Self = load_file_from_env(CONFIG_ENV)?; |
There was a problem hiding this comment.
wonder if we can do something like:
impl TryFrom<&'static str> for CommitBoostConfigand then
let config = CommitBoostConfig::try_from(CONFIG_ENV)?;There was a problem hiding this comment.
Yeah think we can improve in general how configs are loaded, will keep it in a separate PR
fbrv
approved these changes
Sep 30, 2024
barnabasbusa
added a commit
to ethpandaops/ethereum-package
that referenced
this pull request
Oct 17, 2024
Initial support for Commit-Boost, adding for now only the PBS module (equivalent to MEV-Boost). Note that this depends on [this PR](Commit-Boost/commit-boost-client#138) being merged and released. There is sometimes some ambiguity between mev-boost (go client) and mev-boost (protocol via the Builder API), so to disambiguate within commit boost we call the PBS module the sidecar implementing the mev-boost protocol. Here I followed the existing convention as much as possible even if it sounds somewhat repetitive at times (commit-boost-mev-boost). EDIT: the blocking PR is now merged and released in `0.3.0` --------- Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com> Co-authored-by: Barnabas Busa <barnabas.busa@ethereum.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12
also needed for #90
add support for different chain specs