Skip to content

Commit

Permalink
Using collections to disable parallelisation
Browse files Browse the repository at this point in the history
  • Loading branch information
@aaronpowell
aaronpowell committed Aug 29, 2024
1 parent d5703e1 commit 5a33086
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ jobs:
- name: Build
run: dotnet build --no-restore --configuration ${{ env.DOTNET_CONFIGURATION }}
- name: Test
run: dotnet test --no-build --configuration ${{ env.DOTNET_CONFIGURATION }} --collect "XPlat Code Coverage" --results-directory test-results --logger trx -parallel none
run: dotnet test --no-build --configuration ${{ env.DOTNET_CONFIGURATION }} --collect "XPlat Code Coverage" --results-directory test-results --logger trx

- name: Upload test results
uses: actions/upload-artifact@v4
Expand Down
1 change: 1 addition & 0 deletions tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/AssemblyInfo.cs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[assembly: CollectionBehavior(DisableTestParallelization = true)]
2 changes: 2 additions & 0 deletions tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/SwaHostingComponentTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

namespace CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests;

[Collection("Integration Tests")]
public class SwaHostingComponentTests(ITestOutputHelper testOutput) : AspireIntegrationTest<Projects.CommunityToolkit_Aspire_StaticWebApps_AppHost>(testOutput)
{
[Fact]
Expand All @@ -15,6 +16,7 @@ public async Task EmulatorLaunchesOnDefaultPort()

await ResourceNotificationService.WaitForResourceAsync("swa", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30));
await ResourceNotificationService.WaitForResourceAsync("web", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30));
await ResourceNotificationService.WaitForResourceAsync("api", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30));

var response = await httpClient.GetAsync("/");

Check failure on line 21 in tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/SwaHostingComponentTests.cs

View workflow job for this annotation

GitHub Actions / .NET Tests

CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests.SwaHostingComponentTests ► EmulatorLaunchesOnDefaultPort 

Failed test found in:
  _fv-az1503-832_2024-08-29_00_54_37.trx
Error:
  System.Net.Http.HttpRequestException : Connection refused (localhost:4280)
  ---- System.Net.Sockets.SocketException : Connection refused
Raw output 
System.Net.Http.HttpRequestException : Connection refused (localhost:4280)
---- System.Net.Sockets.SocketException : Connection refused
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.AddHttp11ConnectionAsync(QueueItem queueItem)
   at System.Threading.Tasks.TaskCompletionSourceWithCancellation`1.WaitWithCancellationAsync(CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithVersionDetectionAndRetryAsync(HttpRequestMessage request, Boolean async, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.RedirectHandler.SendAsync(HttpRequestMessage request, Boolean async, CancellationToken cancellationToken)
   at Microsoft.Extensions.Http.Logging.LoggingHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
   at Microsoft.Extensions.Http.Resilience.ResilienceHandler.<>c.<<SendAsync>b__3_0>d.MoveNext()
--- End of stack trace from previous location ---
   at Polly.Outcome`1.ThrowIfException()
   at Microsoft.Extensions.Http.Resilience.ResilienceHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.Extensions.Http.Logging.LoggingScopeHttpMessageHandler.<SendCoreAsync>g__Core|5_0(HttpRequestMessage request, Boolean useAsync, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.<SendAsync>g__Core|83_0(HttpRequestMessage request, HttpCompletionOption completionOption, CancellationTokenSource cts, Boolean disposeCts, CancellationTokenSource pendingRequestsCts, CancellationToken originalCancellationToken)
   at CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests.SwaHostingComponentTests.EmulatorLaunchesOnDefaultPort() in /home/runner/work/Aspire/Aspire/tests/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.Tests/SwaHostingComponentTests.cs:line 21
--- End of stack trace from previous location ---
----- Inner Stack Trace -----
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.ThrowException(SocketError error, CancellationToken cancellationToken)
   at System.Net.Sockets.Socket.AwaitableSocketAsyncEventArgs.System.Threading.Tasks.Sources.IValueTaskSource.GetResult(Int16 token)
   at System.Net.Sockets.Socket.<ConnectAsync>g__WaitForConnectWithCancellation|285_0(AwaitableSocketAsyncEventArgs saea, ValueTask connectTask, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectToTcpHostAsync(String host, Int32 port, HttpRequestMessage initialRequest, Boolean async, CancellationToken cancellationToken)

Expand Down
1 change: 1 addition & 0 deletions tests/CommunityToolkit.Aspire.Java.Hosting.EndToEndTests/AssemblyInfo.cs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[assembly: CollectionBehavior(DisableTestParallelization = true)]
5 changes: 3 additions & 2 deletions ...ava.Hosting.EndToEndTests/ProgramTests.cs → ...ndToEndTests/JavaHostingComponentTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@

namespace CommunityToolkit.Aspire.Java.Hosting.EndToEndTests;

public class ProgramTests(ITestOutputHelper testOutput) : AspireIntegrationTest<Projects.CommunityToolkit_Aspire_Java_AppHost>(testOutput)
[Collection("Integration Tests")]
public class JavaHostingComponentTests(ITestOutputHelper testOutput) : AspireIntegrationTest<Projects.CommunityToolkit_Aspire_Java_AppHost>(testOutput)
{
[Fact]
public async Task Given_Container_Resource_When_Invoked_Then_Root_Returns_OK()
Expand All @@ -22,7 +23,7 @@ public async Task Given_Container_Resource_When_Invoked_Then_Root_Returns_OK()
[Fact]
public async Task Given_Executable_Resource_When_Invoked_Then_Root_Returns_OK()
{
var httpClient = app.CreateHttpClient("containerapp");
var httpClient = app.CreateHttpClient("executableapp");

await ResourceNotificationService.WaitForResourceAsync("executableapp", KnownResourceStates.Running).WaitAsync(TimeSpan.FromSeconds(30));

Expand Down

0 comments on commit 5a33086

Please sign in to comment.