Add EventStore Hosting and Client integrations #277
+2,062
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
requested changes
Nov 22, 2024
src/CommunityToolkit.Aspire.Hosting.EventStore/EventStoreBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.EventStore/EventStoreBuilderExtensions.cs
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.EventStore.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.EventStore.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.EventStore.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.EventStore.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.EventStore.Tests/EventStorePublicApiTests.cs
Outdated
Show resolved
Hide resolved
Addressed in this commit: 8fc728b |
fredimachado
force-pushed
the
eventstore-integration
branch
from
c91cf2c
to
1302216
Compare
aaronpowell
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Looks really good @fredimachado
I've kicked off a build, once it's clean we can look to merge it in.
You should also have an invite to the contributor team (which will sort out the CODEOWNERS)
Alirexaa
reviewed
Nov 25, 2024
| sp => new EventStoreHealthCheck(settings.ConnectionString!), | ||
| failureStatus: default, | ||
| tags: default, | ||
| timeout: default)); |
There was a problem hiding this comment.
Could you add a HealthCheckTimeout property with TimeSpan type to EventStoreSetting and use it here?
There was a problem hiding this comment.
Addressed in this commit 9bb0b5d
src/CommunityToolkit.Aspire.Hosting.EventStore/EventStoreBuilderExtensions.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236
This pull request includes several updates to the Aspire CommunityToolkit including new projects for EventStore Hosting and Client integrations, a simple "bank account" example project, tests and updates to dependencies.
Project Additions and Updates:
Added new EventStore projects to the solution, including
Aspire.CommunityToolkit.Hosting.EventStore,Aspire.CommunityToolkit.EventStore, and their respective test and example projects.Dependency Updates:
Added new dependencies in
Directory.Packages.props, includingAspNetCore.HealthChecks.EventStore.gRPC,EventStore.Client.Extensions.OpenTelemetry, andEventStore.Client.Grpc.Streams. (Directory.Packages.props) [1]Code Ownership:
Updated the CODEOWNERS file to include new EventStore projects and assigned ownership to @fredimachado. (CODEOWNERS)
New Example Project:
Added a simple "bank account" example project for EventStore service. (examples/eventstore/Aspire.CommunityToolkit.Hosting.EventStore.ApiService) [1]
PR Checklist
Other information
Docs PR: dotnet/docs-aspire#2143