Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New experiment improvements #131

Merged
merged 20 commits into from
Jun 7, 2022
Merged

Conversation

mrlacey
Copy link
Contributor

@mrlacey mrlacey commented May 23, 2022

Fixes #127

This improves the template for creating a new experiment so that it is more useful and removes possible issues.

@mrlacey mrlacey marked this pull request as ready for review May 23, 2022 18:47
template/README.md Outdated Show resolved Hide resolved
template/README.md Outdated Show resolved Hide resolved
mrlacey and others added 2 commits May 24, 2022 17:17
Co-authored-by: Arlo <arlo.godfrey@outlook.com>
Co-authored-by: Arlo <arlo.godfrey@outlook.com>
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, if we use ProjectTemplate it should auto-relpace on creation, right? That'll make the guidance directly applicable to the locations in the solution which could be handy?

template/README.md Show resolved Hide resolved
template/README.md Outdated Show resolved Hide resolved
template/README.md Outdated Show resolved Hide resolved
template/README.md Outdated Show resolved Hide resolved
template/README.md Outdated Show resolved Hide resolved
mrlacey and others added 8 commits May 26, 2022 12:36
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
to reference the code being developed
& to use a naming convention better matched to the wider toolkit convention
…d code

This is to reduce the effort required to begin work on an experiment.
@mrlacey
Copy link
Contributor Author

mrlacey commented May 30, 2022

I'm inclined to add references to Microsoft.Toolkit.Uwp.UI and Community.Toolkit.WinUI.UI in the appropriate test projects as many of the existing tests in the toolkit reference this for access to helper classes when creating UI related tests.
Any thoughts on this?
Any reason not to?
Any other packages to include by default too?

This goal of doing this is to make it easier for anyone creating an experiment to be able to write tests without having to "faff" with adding multiple packages (in different projects) when this is a common task we can do for them.
This would be as a complement to (but not in directly related to) #132

@mrlacey
Copy link
Contributor Author

mrlacey commented Jun 1, 2022

@michael-hawker
Copy link
Member

I'm inclined to add references to Microsoft.Toolkit.Uwp.UI and Community.Toolkit.WinUI.UI in the appropriate test projects as many of the existing tests in the toolkit reference this for access to helper classes when creating UI related tests. Any thoughts on this? Any reason not to? Any other packages to include by default too?

Sorry, missed this comment. Yes, we should do this for the template as well I guess. I think we had discussed adding some common references so that folks can just remove them. That can be done with #132, which now has a PR open here: #139.

@michael-hawker michael-hawker merged commit e6389b0 into main Jun 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the i127-NewExperimentImprovements branch June 7, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the "new experiment" experience
3 participants