Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize component folders #369

Merged
merged 9 commits into from
Feb 23, 2023
Merged

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe changed the base branch from main to refactor/generated-project-heads February 21, 2023 21:03
@delete-merged-branch delete-merged-branch bot deleted the branch main February 21, 2023 21:44
@Arlodotexe Arlodotexe changed the base branch from refactor/generated-project-heads to main February 21, 2023 21:49
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass on GH review. Will try in codespaces in a bit.

@Arlodotexe Arlodotexe force-pushed the refactor/component-folder-structure branch from 9bb888c to 4fc830a Compare February 21, 2023 22:01
@michael-hawker michael-hawker force-pushed the refactor/component-folder-structure branch from 54cb014 to 930308d Compare February 22, 2023 00:09
@niels9001
Copy link
Collaborator

Love how more clean this is :)!

@michael-hawker
Copy link
Member

The all solution is really clean now! 🦙❤

image

@michael-hawker
Copy link
Member

michael-hawker commented Feb 22, 2023

@Arlodotexe got an error running WASM app-app head locally:

image

Same for WinAppSDK (PropertySizer):

image

And UWP (SettingsCard):

image

@Arlodotexe
Copy link
Member Author

Should be fixed now!

@Arlodotexe Arlodotexe merged commit af480df into main Feb 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the refactor/component-folder-structure branch February 23, 2023 20:58
@Arlodotexe Arlodotexe linked an issue Mar 3, 2023 that may be closed by this pull request
Martin1994 pushed a commit to Martin1994/Labs-Windows that referenced this pull request Sep 2, 2023
…r/component-folder-structure

Organize component folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all references to "Labs" in the ./common/ folder Flatten Folder Structure (MAX_PATH)
3 participants