Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UpdateCaptionButtons #461

Merged
merged 2 commits into from
Jul 7, 2023
Merged

UpdateCaptionButtons #461

merged 2 commits into from
Jul 7, 2023

Conversation

ghost1372
Copy link
Contributor

Update Caption Buttons when theme is changing
#459

Animation

niels9001
niels9001 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Will merge this in for now, but we might want to revise for WASDK1.4 as I believe this issue will be fixed there. We also need to consider using predefined brushes for Foreground colors to properly support HighContrast mode?

@niels9001 niels9001 merged commit 3e63cd7 into CommunityToolkit:niels9001/titlebar-experiment Jul 7, 2023
@ghost1372
Copy link
Contributor Author

ghost1372 commented Jul 7, 2023 •
edited
Loading

Thanks!!

Will merge this in for now, but we might want to revise for WASDK1.4 as I believe this issue will be fixed there. We also need to consider using predefined brushes for Foreground colors to properly support HighContrast mode?

WASDK 1.4-preview 1 Recently released, I will try to test it
https://www.nuget.org/packages/Microsoft.WindowsAppSDK/1.4.230628000-preview1

--

i tested, and 1.4-preview1 does not support yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niels9001 niels9001 niels9001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghost1372 @niels9001