Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed sample not picking up source-defined MultiTarget value, fixed compiler error #27

Merged
merged 2 commits into from
Mar 20, 2023
Merged

Fixed sample not picking up source-defined MultiTarget value, fixed compiler error #27

merged 2 commits into from
Mar 20, 2023

Conversation

Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Mar 20, 2023 •
edited
Loading

This PR fixes:

  • An issue where a MultiTarget value defined in a source project wasn't picked up by the sample project.
  • A compiler error that occurs when the only component doesn't support all MultiTargets. The WASM head was generating an empty registry while the UWP and WinAppSDK heads were not. Would also happen if no component in the solution supported a MultiTarget you had loaded.

@Arlodotexe Arlodotexe added bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments labels Mar 20, 2023
@Arlodotexe
Copy link
Member Author

Arlodotexe commented Mar 20, 2023 •
edited
Loading

Needed to close off CommunityToolkit/Windows#1

Arlodotexe added a commit to CommunityToolkit/Windows that referenced this pull request Mar 20, 2023
@Arlodotexe
Updated submodule with fixes from CommunityToolkit/Tooling-Windows-Su…
99c962d 
…bmodule#27
@michael-hawker michael-hawker merged commit a51f903 into main Mar 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/multitarget/sample-not-inheriting-from-source branch March 20, 2023 19:25
@Arlodotexe Arlodotexe mentioned this pull request Mar 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something isn't working dev loop ➰ For issues that impact the core dev-loop of building experiments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arlodotexe @michael-hawker