Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting RangeSelector #44

Merged
merged 12 commits into from
May 8, 2023
Merged

Porting RangeSelector #44

merged 12 commits into from
May 8, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented May 4, 2023 •
edited
Loading

Addressing #37.

  • Ported over current RangeSelector.
  • Updated visual style so it's inline with WinUI 2.5+
  • Ported over tests, sample and docs
  • Tested on UWP, WASDK and WASM

Before:
image

After:
RangeSelector

@niels9001 niels9001 mentioned this pull request May 4, 2023
Closed
@niels9001 niels9001 requested a review from Arlodotexe May 4, 2023 14:31
@niels9001 niels9001 marked this pull request as ready for review May 4, 2023 14:32
@Arlodotexe
Copy link
Member

@niels9001 Looks like UWP has a failing test, and WinAppSDK has a malformed source header

@niels9001 niels9001 merged commit e1fa09f into main May 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the niels9001/rangeselector-port branch May 8, 2023 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arlodotexe Arlodotexe Arlodotexe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niels9001 @Arlodotexe