rails 4 beta support #59

slbug · 2012-08-07T21:42:58Z

I think it's time to do it :)

jeshuaborges · 2012-09-11T17:19:51Z

👍

nevir · 2012-09-21T16:36:08Z

No issues with this branch so far for me :)

scottdavis · 2012-09-21T19:36:46Z

I hope to get this merged soon been super busy latley

On Fri, Sep 21, 2012 at 12:36 PM, Ian MacLeod notifications@git.luolix.topwrote:

No issues with this branch so far for me :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-8772234.

ekampp · 2012-10-06T22:39:27Z

👍

olivierlacan · 2012-10-13T04:46:16Z

What's missing for getting merged in?

scottdavis · 2012-10-13T04:47:36Z

My free time =(

Sent from my iPhone

On Oct 13, 2012, at 12:46 AM, Olivier Lacan notifications@github.com wrote:

What's missing for getting merged in?

—
Reply to this email directly or view it on GitHub.

wuputah · 2012-10-31T13:18:12Z

@slbug Any chance of an update? Seems sprockets/rails/static_compiler is no more.

slbug · 2012-11-08T21:42:42Z

Will try soon. Need to dig into sprockets integration

elfassy · 2012-11-26T21:02:02Z

+1

neersighted · 2012-11-27T19:03:53Z

👍

ghempton · 2012-12-13T18:46:44Z

👍

balexand · 2012-12-14T19:54:51Z

+1

ai · 2012-12-18T18:14:35Z

I need this fix too.

ai · 2012-12-18T18:40:25Z

@slbug when I use your fork on edge Rails, and sprockets-rails 2.0.0.rc1, I get cannot load such file -- sprockets/rails/static_compiler (LoadError)

ai · 2012-12-18T18:52:43Z

@slbug problem is that you fork stable branch, not master, where there isn’t static compiler patch.

slbug · 2012-12-18T19:30:30Z

@ai, i've used master branch, but static compiler was removed after i created this pull request. And atm i don't have time to update it.

ai · 2012-12-18T19:38:00Z

@slbug after I fix static compiler issue I have abother problem: File to import not found or unreadable: compass/css3. compass-rails copy compass options to Sass options, but, as I understand, Sass importer doesn’t use this Sass options to load Compass files :(.

ai · 2012-12-18T21:10:48Z

The second problem in Rails 4 and Compass is that Sass template compiler is now directly in the sprockets gem, not in sass-rails. So new Sass compelier doesn’t know anything about Rails, and it just take load_paths only from Assets Pipeline, not from Rails.application.config.sass.load_paths.

I create really quick hack to enable Compass in Rails 4.

machty · 2012-12-30T05:24:48Z

Quick, potentially obselete comment: whatever the solution with integration Rails 4 is, Compass ought to provide a generalized interface for files generated in the compilation process, and not just particularly for sprite images. I had enough of a wretched time mimicking the Rails 3 + compass-rails hack to get something similar to auto-sprite-generation working, so whatever the Rails 4 integration, I'd just make sure Compass plugins have some api for registering their mid-compile generated assets.

scottdavis · 2013-01-09T16:51:11Z

Just want to keep everyone in the loop this is on my list of things to get done. We are trying to set up a hack weekend to get the next version of compass out the door. Once that has happened i will get rails 4 support released

mrleeio · 2013-01-09T18:31:28Z

Awesome, I'm having no luck with the hack posted by ai.

take · 2013-01-10T17:56:53Z

omg when will this be merged :D

milgner · 2013-01-14T20:57:03Z

Great work, looking forward to official Rails 4 support! For the time being, I merged together the changes by @slbug and @ai. You can find the branch at milgner/compass-rails@1749c06f15dc4b058427e7969810457213647fb8

As far as I can see after a short testdrive, everything works fine.

rubiii · 2013-01-22T21:29:52Z

@milgner tried your branch and it works for me. thanks!

frodsan · 2013-01-22T22:59:58Z

lib/compass-rails/patches/static_compiler.rb

-    def write_manifest_with_sprites(manifest)
-      write_manifest_without_sprites(manifest.merge(self.class.generated_sprites))
+if CompassRails.rails4?
+  require 'sprockets/rails/static_compiler'


I think this no longer exists in sprockets-rails.

Any suggestions what to do about this? It's causing errors for me.

woto · 2013-01-25T15:47:46Z

👍 where is rails4 support? :(

ghost · 2013-02-04T20:34:54Z

@milgner, or others:

Any instructions for how to get this working with Rails 4? I've tried to integrate the various branches here without success (I blame myself).

One of the first issues I'm seeing is a warning when starting the Rails server: 'Unsupported rails environment for compass' (Compass is a dependency of the Foundation framework, which I'm attempting to use with Rails 4).

chrisnicola · 2013-02-04T20:37:12Z

@narmy I found this ref did it for me: https://github.com/milgner/compass-rails/commit/1749c06f15dc4b058427e7969810457213647fb8

jduarte · 2013-07-01T23:07:03Z

Have you tried remove it from the assets group? I'm not 100% sure if it
were removed from Rails 4 but in the RC's:

Now, according to the (still in progress) upgrade
documentationhttp://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-3-2-to-rails-4-0
:

Rails 4.0 removed the assets group from Gemfile. You'd need to remove that
line from your Gemfile when upgrading.

On Mon, Jul 1, 2013 at 11:53 PM, Alexandre Gaudencio <
notifications@github.com> wrote:

Hi guys.

This solution doesn't seem to be working to me :(

Here's my gem file :

source 'https://rubygems.org'

Bundle edge Rails instead: gem 'rails', github: 'rails/rails'gem 'rails', '4.0.0'

Use sqlite3 as the database for Active Recordgem 'sqlite3'

group :assets do
# Use SCSS for stylesheets
gem 'sass-rails', '~> 4.0.0'
gem "compass-rails", github: "milgner/compass-rails", ref: "1749c06f15dc4b058427e7969810457213647fb8"end

Use Uglifier as compressor for JavaScript assetsgem 'uglifier', '>= 1.3.0'

See https://github.com/sstephenson/execjs#readme for more supported runtimes# gem 'therubyracer', platforms: :ruby

Use jquery as the JavaScript librarygem 'jquery-rails'

group :development, :test do
gem 'better_errors'
gem 'binding_of_caller'
gem 'pry'end

Use ActiveModel has_secure_password# gem 'bcrypt-ruby', '~> 3.0.0'

Use unicorn as the app server# gem 'unicorn'

Use Capistrano for deployment# gem 'capistrano', group: :development

Use debugger# gem 'debugger', group: [:development, :test]

And I just keep on getting

File to import not found or unreadable: compass/css3.

I've read this whole topic but the given solution (the hacked branch from
@milgner https://github.com/milgner ) doesn't work for me for some
reason (that I can't find)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/59#issuecomment-20316303
.

José Duarte

Shahor · 2013-07-02T00:06:12Z

@jduarte Excellent, thanks for the suggestion 👍
It works like a charm now.

scottdavis · 2013-07-03T02:08:59Z

For those of you who have this working I have 2 questions.

Do sprites work corretly
Does the precompile for production work correctly

rdj · 2013-07-03T02:26:58Z

Those are the two things I was having problems with. Specifically, one sprite worked ok, but subsequent sprites didn't work. And then the production compile didn't seem like it was going to "just work". So I rolled back to Rails 3.2 for now.

scottdavis · 2013-07-03T04:34:12Z

Ihave spent about 2 hours now digging into this. I got everything working but sprites and precompile. since the new precompile method uses a rake task i have no way at getting at the manifest instance to append the compiled sprites other then this hack:

manifest = nil
ObjectSpace.each_object(::Sprockets::Manifest) { |o| manifest ||= o}
manifest.assets[logical_path.to_s] = asset.digest_path

Im not ok with shipping this with compass rails since well its gross and could have unexpected results if things were running threads so... unless someone knows how to get a handle to the current objects in a rake task or sprockets exposes an interface for adding objects to the manifest on the fly I'm not sure i can get this working properly

scottdavis · 2013-07-03T04:36:56Z

link to what i was working on https://github.com/Compass/compass-rails/blob/rails4-hack/lib/compass-rails/railties/4_0.rb#L73-L77

frgooall · 2013-07-03T05:09:24Z

Also reporting that

gem 'compass-rails', github: 'milgner/compass-rails', ref: '1749c06f15dc4b058427e7969810457213647fb8'

Work for me as well!

scottdavis · 2013-07-03T05:12:56Z

@frgooall I can guarantee these 2 things are not working #59 (comment). you are going to have a bad time when you try and deploy

frgooall · 2013-07-03T10:53:55Z

Okay, thanks for the heads up! does the Rails4 branch work?

nogenhat · 2013-07-03T19:49:33Z

@scottdavis still, have a problem with your branch:
different prefix: "" and "APP_PATH/app/assets/fonts"

scottdavis · 2013-07-03T19:52:14Z

@reizenikker can you be more descriptive

nogenhat · 2013-07-03T19:53:45Z

@scottdavis i will try.
rake assets:precompile on development compile normally.
but on production, like RAILS_ENV=production rake assets:precompile
executed with this error

scottdavis · 2013-07-03T20:02:58Z

@reizenikker could you set up a small test project that duplicates this error?

nogenhat · 2013-07-03T20:04:18Z

of course

Ivan Nastyukhin

On Thursday, July 4, 2013 at 12:03 AM, Scott Davis wrote:

@reizenikker (https://github.com/reizenikker) could you set up a small test project that duplicates this error?

—
Reply to this email directly or view it on GitHub (#59 (comment)).

nogenhat · 2013-07-04T07:18:08Z

@scottdavis
Look at this,
https://github.com/reizenikker/compass_rails_app

stereoscott · 2013-07-12T15:22:20Z

@scottdavis I'd be happy to try and pick up where you left off on this rails4-hack branch if you want to point me in the right direction...

scottdavis · 2013-07-12T18:13:52Z

Just needs test cases added and the rails4 branch merged in

Sent from my iPhone

On Jul 12, 2013, at 11:22 AM, Scott M notifications@github.com wrote:

@scottdavis I'd be happy to try and pick up where you left off on this rails4-hack branch if you want to point me in the right direction...

—
Reply to this email directly or view it on GitHub.

aledalgrande · 2013-07-19T11:03:08Z

This worked for me as well:

gem 'compass-rails', github: 'milgner/compass-rails', branch: 'rails4'

pccjamie · 2013-07-19T19:47:44Z

Thanks for your work on this Scott. Rails dev student. Looking forward to when I know enough to be able to contribute to projects like this.

scottdavis · 2013-07-25T16:03:50Z

cc0df72

Please file any bugs under a new issue

http://rubygems.org/gems/compass-rails/versions/2.0.alpha.0

ghost · 2013-07-27T17:38:26Z

Thanks @scottdavis!

robrobbins · 2013-07-29T17:21:48Z

+1

Shahor · 2013-07-29T22:50:20Z

Thanks 👍

burisu · 2013-08-06T11:53:54Z

Thanks for your work.

kirs · 2013-09-25T12:47:57Z

Thanks!

pSenthil202 · 2013-09-30T06:02:14Z

Thanks +1

slbug added 2 commits August 7, 2012 23:24

rails 4 beta support

418373e

Update test/helpers/file_helper.rb

2bc5ab9

frodsan reviewed Jan 22, 2013
View reviewed changes

kenips referenced this pull request in tsechingho/chosen-rails Jul 22, 2013

require compass-rails by default

2dadbda

scottdavis closed this Jul 25, 2013

reconstructions mentioned this pull request Nov 22, 2013

compass-rails: Is it ready for Rails 4? Not ready. #106

Closed

tompave mentioned this pull request Nov 28, 2013

Rails 4.0, how to make it work #108

Closed

rails 4 beta support #59

rails 4 beta support #59

Conversation

slbug commented Aug 7, 2012

jeshuaborges commented Sep 11, 2012

nevir commented Sep 21, 2012

scottdavis commented Sep 21, 2012

ekampp commented Oct 6, 2012

olivierlacan commented Oct 13, 2012

scottdavis commented Oct 13, 2012

wuputah commented Oct 31, 2012

slbug commented Nov 8, 2012

elfassy commented Nov 26, 2012

neersighted commented Nov 27, 2012

ghempton commented Dec 13, 2012

balexand commented Dec 14, 2012

ai commented Dec 18, 2012

ai commented Dec 18, 2012

ai commented Dec 18, 2012

slbug commented Dec 18, 2012

ai commented Dec 18, 2012

ai commented Dec 18, 2012

machty commented Dec 30, 2012

scottdavis commented Jan 9, 2013

mrleeio commented Jan 9, 2013

take commented Jan 10, 2013

milgner commented Jan 14, 2013

rubiii commented Jan 22, 2013

frodsan Jan 22, 2013

Choose a reason for hiding this comment

chrisnicola Feb 1, 2013

Choose a reason for hiding this comment

woto commented Jan 25, 2013

ghost commented Feb 4, 2013

chrisnicola commented Feb 4, 2013

jduarte commented Jul 1, 2013

Bundle edge Rails instead: gem 'rails', github: 'rails/rails'gem 'rails', '4.0.0'

Use sqlite3 as the database for Active Recordgem 'sqlite3'

Use Uglifier as compressor for JavaScript assetsgem 'uglifier', '>= 1.3.0'

See https://github.com/sstephenson/execjs#readme for more supported runtimes# gem 'therubyracer', platforms: :ruby

Use jquery as the JavaScript librarygem 'jquery-rails'

Use ActiveModel has_secure_password# gem 'bcrypt-ruby', '~> 3.0.0'

Use unicorn as the app server# gem 'unicorn'

Use Capistrano for deployment# gem 'capistrano', group: :development

Use debugger# gem 'debugger', group: [:development, :test]

Shahor commented Jul 2, 2013

scottdavis commented Jul 3, 2013

rdj commented Jul 3, 2013

scottdavis commented Jul 3, 2013

scottdavis commented Jul 3, 2013

frgooall commented Jul 3, 2013

scottdavis commented Jul 3, 2013

frgooall commented Jul 3, 2013

nogenhat commented Jul 3, 2013

scottdavis commented Jul 3, 2013

nogenhat commented Jul 3, 2013

scottdavis commented Jul 3, 2013

nogenhat commented Jul 3, 2013

nogenhat commented Jul 4, 2013

stereoscott commented Jul 12, 2013

scottdavis commented Jul 12, 2013

aledalgrande commented Jul 19, 2013

pccjamie commented Jul 19, 2013

scottdavis commented Jul 25, 2013

ghost commented Jul 27, 2013

robrobbins commented Jul 29, 2013

Shahor commented Jul 29, 2013

burisu commented Aug 6, 2013

kirs commented Sep 25, 2013

pSenthil202 commented Sep 30, 2013