Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-7455: Add the ability to suppress warning. #316

Merged

Conversation

Vincent056
Copy link

@Vincent056 Vincent056 commented May 9, 2023

We added a way to hide warning message for rules that has hide warning tag, this addresses issue in OCPBUGS-7455

This works in conjunction with ComplianceAsCode/content#10539.

@openshift-ci openshift-ci bot requested review from rhmdnd and xiaojiey May 9, 2023 08:14
@openshift-ci openshift-ci bot added the approved label May 9, 2023
We added a way to hide warning message for rules that has hide warning tag, this addresses issue in OCPBUGS-7455(https://issues.redhat.com/browse/OCPBUGS-7455)
@Vincent056 Vincent056 changed the title Add the ability to suppresse warning. OCPBUGS-7455: Add the ability to suppresse warning. May 9, 2023
@openshift-ci-robot
Copy link
Collaborator

@Vincent056: This pull request references Jira Issue OCPBUGS-7455, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We added a way to hide warning message for rules that has hide warning tag, this addresses issue in OCPBUGS-7455

This works in conjunction with ComplianceAsCode/content#10539.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Vincent056 Vincent056 changed the title OCPBUGS-7455: Add the ability to suppresse warning. OCPBUGS-7455: Add the ability to suppress warning. May 9, 2023
@jhrozek
Copy link

jhrozek commented May 9, 2023

/jira refresh

@openshift-ci-robot
Copy link
Collaborator

@jhrozek: This pull request references Jira Issue OCPBUGS-7455, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d6ea6ab into ComplianceAsCode:master May 9, 2023
@openshift-ci-robot
Copy link
Collaborator

@Vincent056: Jira Issue OCPBUGS-7455: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-7455 has been moved to the MODIFIED state.

In response to this:

We added a way to hide warning message for rules that has hide warning tag, this addresses issue in OCPBUGS-7455

This works in conjunction with ComplianceAsCode/content#10539.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants