Expose test clean up issues in compliance scan controller

[rhmdnd]

While in the process of updating the controller-runtime from 0.15.0 to
0.16.2, I noticed some strange failures in the unit tests. Specifically,
it didn't look like some of the resources were getting cleaned up
properly, even though we attempt to create them before each spec.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhmdnd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhmdnd]

This is failing because the error returned is a 409, even though we expect createFakeRsSecret to create the secret we want to test with...

Seems like something isn't cleaning up properly?

[rhmdnd]

Recreated the issue in CI:

 • Failure in Spec Setup (BeforeEach) [1.011 seconds]
Testing compliancescan controller phases
/go/src/github.com/openshift/compliance-operator/pkg/controller/compliancescan/compliancescan_controller_test.go:78
  On the DONE phase
  /go/src/github.com/openshift/compliance-operator/pkg/controller/compliancescan/compliancescan_controller_test.go:431
    with delete flag off
    /go/src/github.com/openshift/compliance-operator/pkg/controller/compliancescan/compliancescan_controller_test.go:432
      Should return success & preserve resources [BeforeEach]
      /go/src/github.com/openshift/compliance-operator/pkg/controller/compliancescan/compliancescan_controller_test.go:451
      Unexpected error:
              
          <*errors.StatusError | 0xc00028eaa0>: 
          secrets "result-server-cert-test" already exists
          {
              ErrStatus: {
                  TypeMeta: {Kind: "", APIVersion: ""},
                  ListMeta: {
                      SelfLink: "",
                      ResourceVersion: "",
                      Continue: "",
                      RemainingItemCount: nil,
                  },
                  Status: "Failure",
                  Message: "secrets \"result-server-cert-test\" already exists",
                  Reason: "AlreadyExists",
                  Details: {
                      Name: "result-server-cert-test",
                      Group: "",
                      Kind: "secrets",
                      UID: "",
                      Causes: nil,
                      RetryAfterSeconds: 0,
                  },
                  Code: 409,
              },
          }
      occurred
      /go/src/github.com/openshift/compliance-operator/pkg/controller/compliancescan/compliancescan_controller_test.go:439 

[openshift-merge-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	ae1709d	link	true	/test unit
ci/prow/images	ae1709d	link	true	/test images
ci/prow/e2e-rosa	ae1709d	link	true	/test e2e-rosa
ci/prow/e2e-aws-serial	ae1709d	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-parallel	ae1709d	link	true	/test e2e-aws-parallel

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhmdnd]

Closing this since we're updated to a newer version of controller-runtime.

679d325

[rhmdnd]

#583