Introduce a file for assertions #424
Conversation
We have a smattering of assertions in different files within the `framework` package. Even if you rely on your IDE to fill these in for you, organizing them is good practice. This commit adds a new file specifically for assertions, and populates it with an existing assertion used in tests. It also implements the ability for assertions to handle test outcomes, instead of returning booleans, forcing the callers to handle test outcomes. Although having test outcomes (e.g., `FailNow`) in the test is clear, we check and call `Fatal` a lot across the test code. Moving the outcome into the assertion allows the code to be a little more dry, and clear if everyone agrees assertions should accept that reponsibility.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhmdnd
requested review from
yuumasato and
Vincent056
and removed request for
jhrozek
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We have a smattering of assertions in different files within the
frameworkpackage. Even if you rely on your IDE to fill these in foryou, organizing them is good practice.
This commit adds a new file specifically for assertions, and populates
it with an existing assertion used in tests.
It also implements the ability for assertions to handle test outcomes,
instead of returning booleans, forcing the callers to handle test
outcomes. Although having test outcomes (e.g.,
FailNow) in the test isclear, we check and call
Fatala lot across the test code. Moving theoutcome into the assertion allows the code to be a little more dry, and
clear if everyone agrees assertions should accept that reponsibility.