Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 update golang to 1.21 #491

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

rhmdnd
Copy link

@rhmdnd rhmdnd commented Feb 2, 2024

No description provided.

Copy link

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 2, 2024
@BhargaviGudi
Copy link
Collaborator

Verification passed with 4.15.0-rc.5 + code from PR #491

  1. Install CO with PR 🧹 update golang to 1.21 #491
  2. Create ssb
$ oc compliance bind -N test -S default-auto-apply profile/ocp4-cis profile/ocp4-cis-node
Creating ScanSettingBinding test
$ oc get suite -w
NAME   PHASE         RESULT
test   AGGREGATING   NOT-AVAILABLE
test   AGGREGATING   NOT-AVAILABLE
test   DONE          NON-COMPLIANT
test   DONE          NON-COMPLIANT
$ oc get pods
NAME                                             READY   STATUS    RESTARTS        AGE
compliance-operator-754cb8f9bf-stlh5             1/1     Running   1 (6m42s ago)   6m47s
ocp4-openshift-compliance-pp-64c669c697-msc8d    1/1     Running   0               6m39s
rhcos4-openshift-compliance-pp-97796b947-5cd8q   1/1     Running   0               6m39s

@BhargaviGudi
Copy link
Collaborator

/label qe-approved

@rhmdnd
Copy link
Author

rhmdnd commented May 15, 2024

This is failing serial and parallel e2e testing due to images with the wrong glibc version:

compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

@rhmdnd
Copy link
Author

rhmdnd commented May 16, 2024

We've been bitten by this before - here is an example of what we did to fix:

#373

@rhmdnd
Copy link
Author

rhmdnd commented Jul 15, 2024

Still failing on GLIB issues:

compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

@rhmdnd rhmdnd force-pushed the go-1.21 branch 2 times, most recently from 0637e40 to aa692ff Compare July 15, 2024 20:38
build/Dockerfile Outdated Show resolved Hide resolved
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:491

@Vincent056
Copy link

compliance-operator: /lib64/libc.so.6: version `GLIBC_2.32' not found (required by compliance-operator)
compliance-operator: /lib64/libc.so.6: version `GLIBC_2.34' not found (required by compliance-operator)

is it because the builder image has different glibc version from the operator base image

@rhmdnd
Copy link
Author

rhmdnd commented Jul 16, 2024

Checking the versions directly.

GLIBC version we were using the golang 1.20:

$ podman run --entrypoint /bin/bash -ti registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.20-openshift-4.14
[root@579d0b336b3b origin]# ldd --version
ldd (GNU libc) 2.28
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
[root@579d0b336b3b origin]# exit
exit

Version with ubi8:

$ podman run -it registry.access.redhat.com/ubi8/ubi-micro
sh-4.4# ldd --version
ldd (GNU libc) 2.28
Copyright (C) 2018 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
sh-4.4# exit
exit

Version we're using with golang 1.21 and RHEL 9:

$ podman run --entrypoint /bin/bash -ti registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.21-openshift-4.16
[root@23c6e683bd58 origin]# ldd --version
ldd (GNU libc) 2.34
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
[root@23c6e683bd58 origin]# exit
exit

Version with ubi9:

$ podman run -it registry.access.redhat.com/ubi9/ubi-micro
sh-5.1# ldd --version
ldd (GNU libc) 2.34
Copyright (C) 2021 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Written by Roland McGrath and Ulrich Drepper.
sh-5.1# exit
exit

@rhmdnd
Copy link
Author

rhmdnd commented Jul 17, 2024

About to kick this one through openshift/release#54429 and then we can retest to see if the GLIBC error goes away.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 17, 2024

/test e2e-rosa
/test e2e-aws-serial
/test e2e-aws-parallel

@rhmdnd
Copy link
Author

rhmdnd commented Jul 17, 2024

Needed to repropose the CI update in openshift/release#54489 due to another PR reverting the update to 1.21

@rhmdnd
Copy link
Author

rhmdnd commented Jul 17, 2024

/retest-required

@rhmdnd
Copy link
Author

rhmdnd commented Jul 17, 2024

/test e2e-aws-parallel

@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

Looks like we're encountering some issues with metrics that are causing the tests to fail. Need to check if this is applicable to master, or somehow related to the golang bump.

@rhmdnd
Copy link
Author

rhmdnd commented Jul 18, 2024

/test e2e-aws-parallel

Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:491

@Vincent056
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8574970 into ComplianceAsCode:master Jul 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants