-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add timestamp annotation #512
[WIP] Add timestamp annotation #512
Conversation
Hi @SimonBaeumer. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SimonBaeumer The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -86,7 +86,7 @@ const CmScanResultAnnotation = "compliance.openshift.io/scan-result" | |||
const CmScanResultErrMsg = "compliance.openshift.io/scan-error-msg" | |||
|
|||
const ( | |||
// ResultNot available represents the compliance scan not having finished yet | |||
// ResultNotAvailable available represents the compliance scan not having finished yet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be // ResultNotAvailable represents the compliance scan not having finished yet
Add timestamp annotation to CheckResult objects.
The goal is to be able to identify when a ComplianceScan is done and has successful update all CheckResults.
Additionally, from a client perspective I want to be able to identify when I received all updated CheckResults. Prior to this change it was not possible to know when a check was done if the result didn't changed.
Specification:
compliance.openshift.io/last-scanned-timestamp
to CheckResult objectcompliance.openshift.io/last-scanned-timestamp
annotation is always updated