Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add timestamp annotation #512

Conversation

SimonBaeumer
Copy link

@SimonBaeumer SimonBaeumer commented May 3, 2024

Add timestamp annotation to CheckResult objects.
The goal is to be able to identify when a ComplianceScan is done and has successful update all CheckResults.
Additionally, from a client perspective I want to be able to identify when I received all updated CheckResults. Prior to this change it was not possible to know when a check was done if the result didn't changed.

Specification:

  • Add compliance.openshift.io/last-scanned-timestamp to CheckResult object
  • compliance.openshift.io/last-scanned-timestamp annotation is always updated
  • CheckResult objects are updated, even if the Result did not changed.

@SimonBaeumer SimonBaeumer marked this pull request as draft May 3, 2024 08:47
@openshift-ci openshift-ci bot requested review from jhrozek and Vincent056 May 3, 2024 08:47
@SimonBaeumer SimonBaeumer changed the title Add timestamp annotation [WIP] Add timestamp annotation May 3, 2024
Copy link

openshift-ci bot commented May 3, 2024

Hi @SimonBaeumer. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SimonBaeumer
Once this PR has been reviewed and has the lgtm label, please assign xiaojiey for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -86,7 +86,7 @@ const CmScanResultAnnotation = "compliance.openshift.io/scan-result"
const CmScanResultErrMsg = "compliance.openshift.io/scan-error-msg"

const (
// ResultNot available represents the compliance scan not having finished yet
// ResultNotAvailable available represents the compliance scan not having finished yet
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be // ResultNotAvailable represents the compliance scan not having finished yet

@rhmdnd rhmdnd added this to the 1.6.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants