Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding test for network policy regex #517

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Vincent056
Copy link

@Vincent056 Vincent056 commented May 10, 2024

Added e2e test for configure-network-policies-namespaces rule, test if whitelist-regex works as expected.

This works in-conjunction with ComplianceAsCode/content#11952

@openshift-ci openshift-ci bot requested review from jhrozek and mrogers950 May 10, 2024 00:22
Copy link

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tests/e2e/serial/main_test.go Show resolved Hide resolved
tests/e2e/serial/main_test.go Outdated Show resolved Hide resolved
@Vincent056
Copy link
Author

/retest

Added e2e test for configure-network-policies-namespaces rule, test if whitelist-regex works as expected
tests/e2e/serial/main_test.go Outdated Show resolved Hide resolved
Co-authored-by: Watson Yuuma Sato <wsato@redhat.com>
@yuumasato
Copy link
Member

Sorry @Vincent056 we got an error on t.Skip()
tests/e2e/serial/main_test.go:1965:3: (*testing.common).Skip call has possible formatting directive %s

@Vincent056
Copy link
Author

/retest

@yuumasato
Copy link
Member

@Vincent056 Still the same error:

# github.com/ComplianceAsCode/compliance-operator/tests/e2e/serial
tests/e2e/serial/main_test.go:1965:3: (*testing.common).Skip call has possible formatting directive %s
FAIL	github.com/ComplianceAsCode/compliance-operator/tests/e2e/serial [build failed]
FAIL
make: *** [Makefile:610: e2e-serial] Error 1

Copy link

openshift-ci bot commented Jul 19, 2024

@Vincent056: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 6dd67e0 link true /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd rhmdnd added this to the 1.6.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants