🧹 remove downstream-specific Dockerfile #545
Conversation
|
Hold until we get good testing signal. |
|
🤖 To deploy this PR, run the following command: |
|
/retest |
|
rosa failures looks unrelated /lgtm |
|
/test e2e-rosa failed to provision the rosa cluster - unrelated to this change. |
|
/test e2e-rosa Another unrelated failure due to the rosa cluster failing to install. |
rhmdnd
force-pushed
the
remove-OCP-Dockerfile
branch
from
de4b1e2
to
5fbb536
Compare
|
Fixed up the remove conflict. @Vincent056 @yuumasato should be ready for another look. |
|
🤖 To deploy this PR, run the following command: |
|
/test images Image registry threw a 500... |
|
Applying px, doc, and qe labels since this isn't used anywhere in our upstream build process and shouldn't require any documentation changes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
|
Tests here are going to fail until we get #523 landed. |
We maintain three different Dockerfiles for similar purposes. One for CI called `Dockerfile.ci`, another for downstream builds called `Dockerfile.ocp`, and another in build/Dockerfile. The downstream Dockerfile isn't used anywhere, so let's remove it so we have less places to update golang versions.
rhmdnd
force-pushed
the
remove-OCP-Dockerfile
branch
from
5fbb536
to
37c201e
Compare
|
🤖 To deploy this PR, run the following command: |
openshift-merge-bot
bot
merged commit 4c90446
into
ComplianceAsCode:master
We maintain three different Dockerfiles for similar purposes. One for CI
called
Dockerfile.ci, another for downstream builds calledDockerfile.ocp, and another in build/Dockerfile.The downstream Dockerfile isn't used anywhere, so let's remove it so we
have less places to update golang versions.