Update bundle annotations to include must-gather image #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have a must-gather image, we should advertise that information through the bundle. We typically do this using `RELATED_IMAGES`, which the operator uses to find container images it needs to do things like profile parsing or scanning. While we can use `RELATED_IMAGES` for the must-gather image, the Compliance Operator doesn't use the must-gather image directly. Instead, we can put it in the annotation of the bundle CSV, so it's still discoverable to users, while not polluting the operator environment with variables it doesn't need.
Merged
|
🤖 To deploy this PR, run the following command: |
JAORMX
approved these changes
Aug 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JAORMX, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test e2e-aws-parallel We have some flakiness in our metrics tests that are causing failures, which has cropped up else where - #302 |
openshift-merge-bot
bot
merged commit 2b1c972
into
ComplianceAsCode:master
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have a must-gather image, we should advertise that information
through the bundle. We typically do this using
RELATED_IMAGES, whichthe operator uses to find container images it needs to do things like
profile parsing or scanning.
While we can use
RELATED_IMAGESfor the must-gather image, theCompliance Operator doesn't use the must-gather image directly. Instead,
we can put it in the annotation of the bundle CSV, so it's still
discoverable to users, while not polluting the operator environment with
variables it doesn't need.