-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BSI reference parser #610
base: master
Are you sure you want to change the base?
Add BSI reference parser #610
Conversation
This adds BSI to the standards annotation: 'policies.open-cluster-management.io/standards: BSI' And adds the requirement number to the following annotaions:: - 'control.compliance.openshift.io/BSI' - 'policies.open-cluster-management.io/controls'
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🤖 To deploy this PR, run the following command:
|
Can we safely land this before the profile is available? IIUC - we should be able to land this code, but it will only get invoked if/when the operator parses the BSI profile. I'm double checking if this can go in prior to the 1.6.0 release, or if we should wait for 1.7.0 development to open. |
I think it is safe to merge before 1.6.0. But is should be fine to wait a bit more... |
/hold for test |
Verification passed with 4.17.0-0.nightly-2024-10-14-225948 + PR #610 + https://github.com/ComplianceAsCode/content code
$ while read rule; do echo "Rule: $rule"; oc get rule $rule -o=jsonpath={.metadata.annotations} | jq -r | grep -e "control.compliance.openshift.io/BSI" -e "policies.open-cluster-management.io/controls" -e "policies.open-cluster-management.io/standards"; done < BSIProfile
|
/unhold |
@rhmdnd @Vincent056 should be good to go |
This adds BSI to the standards annotation:
policies.open-cluster-management.io/standards: BSI
And adds the requirement number to the following annotaions::
control.compliance.openshift.io/BSI
policies.open-cluster-management.io/controls
For example:
$ oc get rule upstream-ocp4-kubeadmin-removed -oyaml