Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ol8 v1r5 small updates - update policy text & remove rule for OL08-00-010510 #10093

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Ol8 v1r5 small updates - update policy text & remove rule for OL08-00-010510 #10093

merged 2 commits into from
Jan 25, 2023

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Jan 19, 2023

Description:

  • Update policy in rule ssh_host_key_permissions
  • Remove rule sshd_disable_compression from OL8 & RHEL8

Rationale:

  • This is to align with latest DISA STIG requirements. v1r5 for OL8 and v1r9 for RHEL8

@Xeicker
Update policy for ssh host key permissions
ec5b332 
This reflects latest DISA change in their requirements

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@Xeicker Xeicker requested review from a team as code owners January 19, 2023 17:04
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

Hi @Xeicker. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Jan 19, 2023
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@Mab879 Mab879 added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. labels Jan 19, 2023
@Mab879 Mab879 added this to the 0.1.66 milestone Jan 19, 2023
Mab879
Mab879 requested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Make sure that you update the variable in the RHEL 8 profile stability as well.

products/rhel8/profiles/stig.profile Show resolved Hide resolved
@Xeicker
Remove sshd_disable_compression from OL8 & RHEL8
b10006d 
Remove the rule from stig profile as the requirement has been deleted
from DISA's requirements

Signed-off-by: Edgar Aguilar <edgar.aguilar@oracle.com>
@codeclimate
Copy link

codeclimate bot commented Jan 20, 2023

Code Climate has analyzed commit b10006d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 49.7% (0.0% change).

View more on Code Climate.

Mab879
Mab879 approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Mab879 Mab879 removed this from the 0.1.66 milestone Jan 23, 2023
@vojtapolasek vojtapolasek self-assigned this Jan 24, 2023
@vojtapolasek
Copy link
Collaborator

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Used by openshift-ci bot. and removed needs-ok-to-test Used by openshift-ci bot. labels Jan 24, 2023
@vojtapolasek vojtapolasek added this to the 0.1.67 milestone Jan 24, 2023
@vojtapolasek
Copy link
Collaborator

@ComplianceAsCode/oracle-maintainers Could you please accept these changes?

@freddieRv freddieRv merged commit 3fdf23d into ComplianceAsCode:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mab879 Mab879 Mab879 approved these changes

@freddieRv freddieRv freddieRv approved these changes

Assignees

@vojtapolasek vojtapolasek

Labels
ok-to-test Used by openshift-ci bot. Oracle Linux Oracle Linux product related. RHEL8 Red Hat Enterprise Linux 8 product related. STIG STIG Benchmark related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.67
Development

Successfully merging this pull request may close these issues.
4 participants
@Xeicker @vojtapolasek @Mab879 @freddieRv