Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrections in the rule package_openldap-clients_removed #10273

Conversation

rumch-se
Copy link
Contributor

@rumch-se rumch-se commented Mar 1, 2023

Description:

  • Corrections of the rule package_openldap-clients_removed related to SLE 12/15

Rationale:

  • The correct name of package in SLE 12/15 is openldap2-clients

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Mar 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

Hi @rumch-se. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@marcusburghardt marcusburghardt added SLES SUSE Linux Enterprise Server product related. Ubuntu Ubuntu product related. labels Mar 1, 2023
@marcusburghardt marcusburghardt added this to the 0.1.67 milestone Mar 1, 2023
@marcusburghardt marcusburghardt added the Update Rule Issues or pull requests related to Rules updates. label Mar 1, 2023
@marcusburghardt marcusburghardt self-assigned this Mar 2, 2023
@rumch-se
Copy link
Contributor Author

rumch-se commented Mar 2, 2023

Hello @marcusburghardt
I have corrected the rule according to your proposal.
Have a nice day
Rumen

@marcusburghardt
Copy link
Member

@rumch-se , could you take and resolve the conflict, please?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Used by openshift-ci bot. label Mar 2, 2023
@marcusburghardt
Copy link
Member

@rumch-se , could you take and resolve the conflict, please?

It needs rebase.

@rumch-se rumch-se force-pushed the rule_package_openldap-clients_removed branch from 06634a8 to afaaca8 Compare March 6, 2023 08:01
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Used by openshift-ci bot. label Mar 6, 2023
@rumch-se rumch-se force-pushed the rule_package_openldap-clients_removed branch from afaaca8 to 726c4a4 Compare March 6, 2023 08:06
@rumch-se
Copy link
Contributor Author

rumch-se commented Mar 6, 2023

Good morning @marcusburghardt
The rebase was done.
Rumen

@codeclimate
Copy link

codeclimate bot commented Mar 6, 2023

Code Climate has analyzed commit 726c4a4 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 51.7% (0.0% change).

View more on Code Climate.

@marcusburghardt marcusburghardt merged commit f31e7b2 into ComplianceAsCode:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Ubuntu Ubuntu product related. Update Rule Issues or pull requests related to Rules updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants