Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure authentication required for single user mode for Ubuntu #10415

Merged
merged 5 commits into from
Apr 4, 2023
Merged

Ensure authentication required for single user mode for Ubuntu #10415

merged 5 commits into from
Apr 4, 2023

Conversation

dodys
Copy link
Contributor

@dodys dodys commented Apr 3, 2023

Description:

  • Ubuntu differ from other distros on single user mode authentication, where we only need to verify that a password for root is set.

Rationale:

  • This is CIS item 1.4.3 Ensure authentication required for single user mode (Automated) for Ubuntu

@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Apr 3, 2023
@dodys dodys requested a review from a team as a code owner April 3, 2023 17:22
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2004 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

marcusburghardt
marcusburghardt requested changes Apr 3, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also include test scenarios, please?

@marcusburghardt marcusburghardt added this to the 0.1.68 milestone Apr 3, 2023
@marcusburghardt marcusburghardt self-assigned this Apr 3, 2023
@dodys
Copy link
Contributor Author

dodys commented Apr 4, 2023

Could you also include test scenarios, please?

done!

@marcusburghardt
Copy link
Member

Could you rebase it, please? It should fix the issue with Fedora test.

@codeclimate
Copy link

codeclimate bot commented Apr 4, 2023

Code Climate has analyzed commit 06643dc and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

marcusburghardt
marcusburghardt approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt
Copy link
Member

Overriding CODEOWNERS as @dodys can't approve his own PR.

@marcusburghardt marcusburghardt merged commit 1f0d5ca into ComplianceAsCode:master Apr 4, 2023
@dodys dodys deleted the singleuser branch April 17, 2023 09:48
@jan-cerny jan-cerny added New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. Ansible Ansible remediation update. OVAL OVAL update. Related to the systems assessments. Bash Bash remediation update. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusburghardt marcusburghardt marcusburghardt approved these changes

Assignees

@marcusburghardt marcusburghardt

Labels
Ansible Ansible remediation update. Bash Bash remediation update. CIS CIS Benchmark related. New Rule Issues or pull requests related to new Rules. OVAL OVAL update. Related to the systems assessments. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.68
Development

Successfully merging this pull request may close these issues.
3 participants
@dodys @marcusburghardt @jan-cerny