Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python3 to the list of build dependencies for RHEL-8+ #10503

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

comps
Copy link
Collaborator

@comps comps commented Apr 27, 2023

Description:

RHEL-8 does not, by default, have /usr/bin/python3 installed, using /usr/libexec/platform-python instead for distribution needs.

This causes CMake to fail to find python:

CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /usr/share/cmake/Modules/FindPythonInterp.cmake:169 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  CMakeLists.txt:128 (find_package)

Note that ie. the SPEC file already has this dependency, it was just missing in the documentation.

Rationale:

I presume we would like RHEL-8 users to be able to build content according to the docs .. ?

RHEL-8 does not, by default, have /usr/bin/python3 installed,
using /usr/libexec/platform-python instead for distribution needs.

This causes CMake to fail to find python:

  CMake Error at /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
    Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE)
  Call Stack (most recent call first):
    /usr/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
    /usr/share/cmake/Modules/FindPythonInterp.cmake:169 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
    CMakeLists.txt:128 (find_package)

Note that ie. the SPEC file already has this dependency, it was just
missing in the documentation.

Signed-off-by: Jiri Jaburek <comps@nomail.dom>
@github-actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate
Copy link

codeclimate bot commented Apr 27, 2023

Code Climate has analyzed commit e32ad0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 52.4% (0.0% change).

View more on Code Climate.

@Mab879 Mab879 self-assigned this Apr 27, 2023
@Mab879 Mab879 added this to the 0.1.68 milestone Apr 27, 2023
@Mab879 Mab879 added the Documentation Update in project documentation. label Apr 27, 2023
@Mab879 Mab879 merged commit 3f2a46d into ComplianceAsCode:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Update in project documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants