Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invoke parent's init function #11400

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

Honny1
Copy link
Collaborator

@Honny1 Honny1 commented Dec 19, 2023

Description:

This PR adds invocation of the parent's init function and removes unnecessary init function overrides.

Rationale:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Dec 19, 2023
Copy link

openshift-ci bot commented Dec 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Honny1 Honny1 added bugfix Fixes to reported bugs. Infrastructure Our content build system OVAL OVAL update. Related to the systems assessments. and removed do-not-merge/work-in-progress Used by openshift-ci bot. labels Dec 19, 2023
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Dec 19, 2023

Code Climate has analyzed commit e94c992 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.5% (0.0% change).

View more on Code Climate.

@Honny1 Honny1 marked this pull request as ready for review December 19, 2023 15:17
@jan-cerny jan-cerny added this to the 0.1.72 milestone Dec 20, 2023
@jan-cerny jan-cerny self-assigned this Dec 20, 2023
Copy link
Collaborator

@jan-cerny jan-cerny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built RHEL 9 content from the upstream master and from this PR branch and I have compared the built ssg-rhel9-oval.xml and I haven't discovered any difference apart from the time stamp.

@jan-cerny jan-cerny merged commit d9af605 into ComplianceAsCode:master Dec 20, 2023
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes to reported bugs. Infrastructure Our content build system OVAL OVAL update. Related to the systems assessments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Class OVALContainer(OVALBaseObject) does not invoke parent's init function
2 participants