-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entities/common.py to use CDumper #11541
Conversation
@@ -128,7 +133,8 @@ def derive_id_from_file_name(filename): | |||
|
|||
def dump_yaml_preferably_in_original_order(dictionary, file_object): | |||
try: | |||
return yaml.dump(dictionary, file_object, indent=4, sort_keys=False) | |||
return yaml.dump(dictionary, file_object, indent=4, sort_keys=False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement. I got a speed up about 6 seconds when building RHEL 9 content.
Can you investigate if this change can be consolidated with ssg/yaml.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated to import yaml_Dumper
from ssg/yaml.py
.
a8cd509
to
507351e
Compare
Code Climate has analyzed commit 507351e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 66.6% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.3% (0.0% change). View more on Code Climate. |
/packit retest-failed |
Description:
Update
ssg/entities/common.py
to useCDumper
.Rationale:
Significant speed up of
compile_all.py
.