Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build empty OVAL #12262

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Build empty OVAL #12262

merged 1 commit into from
Aug 2, 2024

Conversation

jan-cerny
Copy link
Collaborator

If we build a thin data stream for a rule that doesn't contain any OVAL check, the build fails because no OVAL file is generated. In this situation, we will generate a minimal OVAL file that doesn't contain any checks. Unfortunately, not building the OVAL file at all would be difficult to be handle by CMake, therefore, we will have a minimal valid OVAL file as a work around. The artifact doesn't matter because thin data streams aren't shipped.

Fixes: #12228

If we build a thin data stream for a rule that doesn't contain any OVAL
check, the build fails because no OVAL file is generated.  In this
situation, we will generate a minimal OVAL file that doesn't contain any
checks.  Unfortunately, not building the OVAL file at all would be
difficult to be handle by CMake, therefore, we will have a minimal valid
OVAL file as a work around. The artifact doesn't matter because thin
data streams aren't shipped.

Fixes: ComplianceAsCode#12228
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 2, 2024
Copy link

openshift-ci bot commented Aug 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

github-actions bot commented Aug 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Aug 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12262
This image was built from commit: 987d168

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12262

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12262 make deploy-local

Copy link

codeclimate bot commented Aug 2, 2024

Code Climate has analyzed commit 987d168 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.4% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny marked this pull request as ready for review August 2, 2024 13:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Aug 2, 2024
@jan-cerny jan-cerny added this to the 0.1.75 milestone Aug 2, 2024
@jan-cerny jan-cerny added the Infrastructure Our content build system label Aug 2, 2024
@Mab879 Mab879 self-assigned this Aug 2, 2024
@Mab879 Mab879 merged commit 7377bf6 into ComplianceAsCode:master Aug 2, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Our content build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCAP Compilation Error When Using --rule-id with a Single SCE Rule
2 participants