Add ansible remediaton for rsyslog_cron_logging rule #12326
Conversation
The rsyslog_cron_logging rule has a condition to test the scenarios all_facilities_set_rsyslog_conf.pass & all_facilities_set_rsyslog_d.pass, OL7 & OL9 are included in that condition Signed-off-by: Armando Acosta <armando.acosta@oracle.com>
|
Hi @mrkanon. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mrkanon
changed the title
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
This datastream diff is auto generated by the check Click here to see the full diffNew data stream adds ansible remediation for rule 'xccdf_org.ssgproject.content_rule_rsyslog_cron_logging'. |
|
Change in Ansible Please consider using more suitable Ansible module than |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
| - name: "{{{ rule_title }}} - Search if cron configuration exists" | ||
| ansible.builtin.command: 'grep -s "^\s*cron\.\*\s*/var/log/cron$" /etc/rsyslog.conf /etc/rsyslog.d/*.conf' | ||
| register: cron_log_config_exists | ||
| ignore_errors: true |
There was a problem hiding this comment.
it would be great to use failed_when: false
There was a problem hiding this comment.
Thanks for the review, I've updated the solution.
For rsyslog_cron_logging rule Signed-off-by: Armando Acosta <armando.acosta@oracle.com>
mrkanon
force-pushed
the
ansible_rsyslog_cron_logging
branch
from
137e3d5
to
01d239e
Compare
|
Change in Ansible Please consider using more suitable Ansible module than |
|
Code Climate has analyzed commit 01d239e and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.4% (0.0% change). View more on Code Climate. |
Description:
Added
Ansible remediation
Updated
Update oval file to include OL7 and OL9 into a condition to test the scenarios
all_facilities_set_rsyslog_conf.passandall_facilities_set_rsyslog_d.passRationale:
In the task filling gaps in OL9 automation, the rule
rsyslog_cron_logginghas a remediation deficit with ansible. The logic of the remediation was taken of bash remediation